Skip to content

Comments

Run tests on PHP 8.3 and update test suite#85

Merged
clue merged 1 commit intoclue:1.xfrom
yadaiio:test-suite
Dec 19, 2023
Merged

Run tests on PHP 8.3 and update test suite#85
clue merged 1 commit intoclue:1.xfrom
yadaiio:test-suite

Conversation

@yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Dec 19, 2023

This pull request builds on top of #80, #82, #83, #84 and #78.

References: reactphp/socket#300, clue/reactphp-zenity#63, clue/reactphp-csv#33, reactphp/promise-stream#39 and others.

After #83 was merged, I could go on with this pull request, thanks to @clue and @SimonFrings.

@yadaiio
Copy link
Contributor Author

yadaiio commented Dec 19, 2023

Okay, should be fixed right now. 👍

Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for the update, changes LGTM! :shipit:

@clue clue merged commit 52ea569 into clue:1.x Dec 19, 2023
@clue clue added the new feature New feature or request label Dec 19, 2023
@clue clue added this to the v1.5.0 milestone Dec 19, 2023
@yadaiio yadaiio mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants